Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wafv2): add webacl #2152

Merged
merged 1 commit into from
Feb 28, 2025
Merged

feat(wafv2): add webacl #2152

merged 1 commit into from
Feb 28, 2025

Conversation

teeverr
Copy link
Contributor

@teeverr teeverr commented Jan 30, 2025 •
edited
Loading

Description

This PR brings wafv2 WebACL.
https://docs.aws.amazon.com/waf/latest/APIReference/API_WebACL.html

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Testing in progress, it takes time due to a massive combination of parameters and infinite recursion for some fields. The unit tests will be extended soon.

UPD. Testing is finished, everything works fine : )

@teeverr teeverr force-pushed the feature/wafv2-webacl branch from 407e11f to 44ba5bf Compare January 30, 2025 20:04
@teeverr teeverr changed the title feat(wafv2) add webacl [WIP] feat(wafv2): add webacl [WIP] Jan 30, 2025
@teeverr teeverr marked this pull request as draft January 31, 2025 08:35
@MisterMX
Copy link
Collaborator

MisterMX commented Feb 3, 2025

Needs rebase on #2154 (or master if it is merged).

@teeverr teeverr force-pushed the feature/wafv2-webacl branch from d41170e to 8de059e Compare February 5, 2025 14:53
@teeverr teeverr force-pushed the feature/wafv2-webacl branch 11 times, most recently from 91b06b8 to 0fef080 Compare February 26, 2025 12:32
@teeverr
add support for wafv2 webacl
0ee993e 
Signed-off-by: Kirill Sushkov (teeverr) <[email protected]>
@teeverr teeverr force-pushed the feature/wafv2-webacl branch from 0fef080 to 0ee993e Compare February 26, 2025 12:48
@teeverr
Copy link
Contributor Author

teeverr commented Feb 26, 2025

@MisterMX
FYI the testing is finished and the PR is ready for review.

I want to summurize why ack v0.38.1 was used:

  • ACK v0.38.0 or higher is needed to handle aws sdk empty structs("shapes")
  • some wafv2 webacl fields have infinite recursion, that's why configuration of these fields represented as string(json), it is implemented by ignoring of these fields(ignore.field_paths) and then injecting new fields with type string. set.[].ignore: "all" is required for that(supported since ack v0.34.0)

I used this config as a tip

@teeverr teeverr changed the title feat(wafv2): add webacl [WIP] feat(wafv2): add webacl Feb 26, 2025
@teeverr teeverr marked this pull request as ready for review February 26, 2025 13:02
MisterMX
MisterMX approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@MisterMX MisterMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much @teeverr!

@MisterMX MisterMX merged commit 8efa881 into crossplane-contrib:master Feb 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MisterMX MisterMX MisterMX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teeverr @MisterMX